Skip to content

Optionally consume Leeway from git #14567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

Optionally consume Leeway from git #14567

merged 1 commit into from
Nov 16, 2022

Conversation

meysholdt
Copy link
Member

@meysholdt meysholdt commented Nov 9, 2022 •
edited
Loading

Description

Optionally install leeway from git. This is helpful to test new versions of leeway before releasing them.

Related Issue(s)

Fixes #

How to test

werft run github -a leeway-from-git=true from CI to bypass job protection.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@meysholdt meysholdt requested a review from a team November 9, 2022 16:41
@roboquat roboquat added the size/S label Nov 9, 2022
@meysholdt meysholdt force-pushed the me/leeway branch 2 times, most recently from 2b0a7c7 to c756e14 Compare November 9, 2022 18:56
@meysholdt meysholdt requested a review from a team November 9, 2022 19:09
@roboquat roboquat added size/M and removed size/S labels Nov 9, 2022
iQQBot
iQQBot reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@iQQBot iQQBot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need upgrade leeway version before we delete --dont-retag or only remove this flag when leeway-from-git is present? because without this flag, old version leeway will build failed or stuck in somewhere.

.github/workflows/jetbrains-update-backend-latest.yml Outdated
@@ -45,4 +45,4 @@ jobs:
- run: |
gcloud auth configure-docker --quiet
export LEEWAY_WORKSPACE_ROOT=$(pwd)
leeway build -Dversion=latest -DimageRepoBase=eu.gcr.io/gitpod-core-dev/build components/ide/jetbrains/backend-plugin:latest --dont-retag
leeway build -Dversion=latest -DimageRepoBase=eu.gcr.io/gitpod-core-dev/build components/ide/jetbrains/backend-plugin:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with current leeway version, if remove --dont-retag flag, it will build failed, so maybe we need update github action to use latest leeway from git

mads-hartmann
mads-hartmann requested changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't merge this until we cut a new release of Leeway and bump that everywhere. There are quite a few changes on Leeway main that isn't included in v0.3.1 and some of them are breaking, like the removal of --dont-retag

@meysholdt meysholdt force-pushed the me/leeway branch 2 times, most recently from 1cc2ab6 to 13e2dc3 Compare November 10, 2022 16:46
@aledbf
Copy link
Member

aledbf commented Nov 11, 2022

/approve

@aledbf
Copy link
Member

aledbf commented Nov 11, 2022

Here is the change that updates leeway in the dev-environment image #14631

@roboquat roboquat added size/S and removed size/M labels Nov 14, 2022
vulkoingim
vulkoingim reviewed Nov 14, 2022
View reviewed changes
@roboquat roboquat added size/XS and removed size/S labels Nov 14, 2022
@meysholdt
Copy link
Member Author

meysholdt commented Nov 14, 2022 •
edited
Loading

do we need upgrade leeway version before we delete --dont-retag or only remove this flag when leeway-from-git is present? because without this flag, old version leeway will build failed or stuck in somewhere.

We can't merge this until we cut a new release of Leeway and bump that everywhere. There are quite a few changes on Leeway main that isn't included in v0.3.1 and some of them are breaking, like the removal of --dont-retag

Sice Leeway has been released & deployed here, I assume this PR can be merged now.

@roboquat roboquat merged commit 72aab9b into main Nov 16, 2022
@roboquat roboquat deleted the me/leeway branch November 16, 2022 10:09
@roboquat roboquat added the deployed: IDE IDE change is running in production label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mads-hartmann mads-hartmann mads-hartmann approved these changes

@vulkoingim vulkoingim vulkoingim approved these changes

@iQQBot iQQBot iQQBot approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production release-note-none size/XS team: devx team: IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@meysholdt @aledbf @mads-hartmann @vulkoingim @iQQBot @roboquat